Skip to content

chore: add CODEOWNERS for sensitive path review enforcement#236

Merged
mrizzi merged 2 commits into
mainfrom
worktree-TC-5080
Jul 6, 2026
Merged

chore: add CODEOWNERS for sensitive path review enforcement#236
mrizzi merged 2 commits into
mainfrom
worktree-TC-5080

Conversation

@mrizzi

@mrizzi mrizzi commented Jul 6, 2026 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Add CODEOWNERS file at repo root mapping sensitive paths to required reviewers
  • Plugin manifest paths (plugins/sdlc-workflow/.claude-plugin/, .claude-plugin/marketplace.json) require Maintainer/Owner review
  • Core methodology (docs/methodology.md) and governance (CONTRIBUTING.md) require Owner review
  • Uses GitHub usernames (@mrizzi) — to be replaced with team references when org teams are created

Implements TC-5080

Summary by Sourcery

Chores:

  • Introduce a root CODEOWNERS file mapping plugin manifests, methodology docs, and governance docs to required reviewers.

@mrizzi
chore: add CODEOWNERS for sensitive path review enforcement
669ec24 
Map plugin manifests, methodology, and governance documents to
required reviewers to ensure changes to sensitive paths get
appropriate review.

Implements TC-5080

Assisted-by: Claude Code
@sourcery-ai

sourcery-ai Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a root-level CODEOWNERS file to enforce review by specific maintainers/owners for sensitive paths related to plugins, methodology, and governance documents.

File-Level Changes

Change Details Files
Introduce CODEOWNERS-based review enforcement for sensitive plugin, methodology, and governance paths.
  • Add a root-level CODEOWNERS file to the repository.
  • Configure plugin manifest paths to require Maintainer/Owner review via CODEOWNERS entries.
  • Configure core methodology and governance documentation paths to require Owner review via CODEOWNERS entries.
  • Use specific GitHub usernames in CODEOWNERS as temporary owners, to be replaced with team references later.
 CODEOWNERS
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Jul 6, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mrizzi
chore: add ruromero as maintainer reviewer in CODEOWNERS
c98eb8c 
Add @ruromero to plugin manifest paths that require Maintainer-level
review.

Implements TC-5080

Assisted-by: Claude Code
@mrizzi

mrizzi commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Verification Report for TC-5080 (commit c98eb8c)

Check Result Details
Review Feedback N/A No substantive review feedback on this PR
Root-Cause Investigation N/A No sub-tasks created — nothing to investigate
Scope Containment PASS PR touches exactly CODEOWNERS — matches task spec
Diff Size PASS 1 file, 12 lines added — proportionate
Commit Traceability PASS Both commits reference TC-5080
Sensitive Patterns PASS No secrets or credentials detected
CI Status PASS All 3 checks pass (Plugin Validation, Skill Lint, Sourcery)
Acceptance Criteria PASS 6 of 6 criteria met
Test Quality N/A No test files in PR; Eval Quality: N/A
Test Change Classification N/A No test files in PR
Verification Commands N/A No verification commands specified

Overall: PASS

All checks pass. CONTRIBUTING.md does not exist yet (expected from sibling task) — the CODEOWNERS rule is syntactically valid and will activate when the file is created.

This comment was AI-generated by sdlc-workflow/verify-pr v0.12.2.

@mrizzi mrizzi merged commit 07d9a21 into main Jul 6, 2026
3 checks passed
@mrizzi mrizzi deleted the worktree-TC-5080 branch July 6, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mrizzi